YetAnotherForum
Welcome Guest Search | Active Topics | Log In | Register

Think I may see an issue with MAX_CHAR, but not sure
JonHodgson
#1 Posted : Tuesday, January 24, 2017 3:03:09 PM(UTC)
Rank: Member

Groups: Registered
Joined: 5/19/2016(UTC)
Posts: 15
Location: UK

Thanks: 0 times
Was thanked: 0 time(s) in 0 post(s)
So, I'm building in OSX (using Clang in XCode, 64 bit build)

A signed/unsigned warning on this line in sqstdrexx.cpp

if(exp->_nodes[i].type>MAX_CHAR)

made me look at type, and MAX_CHAR

Now, on all platforms other than WIN32, MAX_CHAR is set to 0xFFFFFFFF

But, type is SQRexNodeType which in turn is int.

int on this platform being a 32 bit signed value, i.e. having a maximum of 0x7FFFFFFF

That suggests that type can never be OP_GREEDY or any such value (which are all MAX_CHAR + something)

I'm wondering if I've missed something, because it would seem such a bug would be noticed.
Users browsing this topic
Guest (2)
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.

Clean Slate theme by Jaben Cargman (Tiny Gecko)
Powered by YAF 1.9.4 | YAF © 2003-2010, Yet Another Forum.NET
This page was generated in 0.082 seconds.